Huawei SUN2000: add returnEnergy for grid and battery

[CiNcH83]

Depends on #29805.

Notes:
Huawei does not provide self-consumption information for the inverter (no returnenergy for pv).

[sourcery-ai]

Hey - I've left some high level feedback:

• Renaming the existing energy fields to import/export changes the metric contract; consider either keeping a backward-compatible energy alias or explicitly handling the migration for existing consumers of this template.
• The import register for the battery meter uses two separate if blocks for storageunit 1 and 2; if another value is passed, no address is set, so it may be safer to add an else/default branch or validation to avoid generating an invalid configuration.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Renaming the existing `energy` fields to `import`/`export` changes the metric contract; consider either keeping a backward-compatible `energy` alias or explicitly handling the migration for existing consumers of this template.
- The `import` register for the battery meter uses two separate `if` blocks for `storageunit` 1 and 2; if another value is passed, no address is set, so it may be safer to add an `else`/default branch or validation to avoid generating an invalid configuration.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[CiNcH83]

@andig Think we are missing #29805.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• For the battery returnenergy register selection, consider handling or validating cases where .storageunit is not "1" or "2" to avoid rendering a config without an address.
• The source, included modbus block, and timeout are repeated for each new meter; consider extracting these into a small reusable template/helper to reduce duplication and potential for configuration drift across meters.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- For the battery `returnenergy` register selection, consider handling or validating cases where `.storageunit` is not `"1"` or `"2"` to avoid rendering a config without an address.
- The `source`, included `modbus` block, and `timeout` are repeated for each new meter; consider extracting these into a small reusable template/helper to reduce duplication and potential for configuration drift across meters.

## Individual Comments

### Comment 1
<location path="templates/definition/meter/huawei-sun2000-hybrid.yaml" line_range="180-183" />
<code_context>
+    {{- include "modbus" . | indent 2 }}
+    timeout: {{ .timeout }}
+    register:
+      {{- if eq .storageunit "1" }}
+      address: 37066 # [Energy storage unit 1] Total charge
+      {{- end }}
+      {{- if eq .storageunit "2" }}
+      address: 37753 # [Energy storage unit 2] Total charge
+      {{- end }}
</code_context>
<issue_to_address>
**issue:** Handle the case where `.storageunit` is neither "1" nor "2" to avoid a register without an address.

As written, a `storageunit` value other than "1" or "2" produces a `returnenergy` register with no `address`. This may surface only as a runtime config error downstream. Either validate/constrain `.storageunit` earlier or add a default/`else` branch so invalid values fail explicitly instead of yielding a partially defined register.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[CiNcH83]

/cc @premultiply