Add DSMR API v2 support (Ethernet P1 Dongle Pro+)#29871
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- There is a typo in the help text for
apiversion("smarstuff" instead of "Smartstuff") in both the German and English variants; correcting this will avoid confusion in the UI. - Consider aligning the new product entry with the existing brand/description structure (e.g.,
brand: Smartstuffand a more specificdescription.generic) to keep product metadata consistent with the rest of the template.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There is a typo in the help text for `apiversion` ("smarstuff" instead of "Smartstuff") in both the German and English variants; correcting this will avoid confusion in the UI.
- Consider aligning the new product entry with the existing brand/description structure (e.g., `brand: Smartstuff` and a more specific `description.generic`) to keep product metadata consistent with the rest of the template.
## Individual Comments
### Comment 1
<location path="templates/definition/meter/dsmrlogger-aandewiel.yaml" line_range="24-26" />
<code_context>
+ de: API Version
+ en: API version
+ help:
+ de: "API v1 für DSMR-logger API v1, API v2 für DSMR-logger API v2 (smarstuff P1 Dongle mit DSMR-logger API v2)"
+ en: "Use API v1 for DSMR-logger API v1, use API v2 for DSMR-logger API v2 (smarstuff P1 Dongle with DSMR-logger API v2)"
render: |
</code_context>
<issue_to_address>
**issue (typo):** Fix the "smarstuff" typo in the German help text.
The product name appears as "Smartstuff" elsewhere, so this should be `Smartstuff P1 Dongle` for consistency in the user-facing text.
```suggestion
help:
de: "API v1 für DSMR-logger API v1, API v2 für DSMR-logger API v2 (Smartstuff P1 Dongle mit DSMR-logger API v2)"
en: "Use API v1 for DSMR-logger API v1, use API v2 for DSMR-logger API v2 (Smartstuff P1 Dongle with DSMR-logger API v2)"
```
</issue_to_address>
### Comment 2
<location path="templates/definition/meter/dsmrlogger-aandewiel.yaml" line_range="26" />
<code_context>
+ en: API version
+ help:
+ de: "API v1 für DSMR-logger API v1, API v2 für DSMR-logger API v2 (smarstuff P1 Dongle mit DSMR-logger API v2)"
+ en: "Use API v1 for DSMR-logger API v1, use API v2 for DSMR-logger API v2 (smarstuff P1 Dongle with DSMR-logger API v2)"
render: |
{{- define "uri" -}}
</code_context>
<issue_to_address>
**nitpick (review_instructions):** "smarstuff" is a typo and inconsistent with the "Smartstuff DSMR-logger API" wording used above.
The brand is spelled "Smartstuff" in the `products` section, but in this help text it is spelled "smarstuff". Please correct the spelling to keep wording consistent across this template and with other templates.
<details>
<summary>Review instructions:</summary>
**Path patterns:** `templates/**/*.yaml`
**Instructions:**
Verify that the changes comply to the rules defined in templates/README.md. Also check consistence (wording) with other files inside templates directory.
</details>
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Aligning the naming Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
hbourmorck
pushed a commit
to hbourmorck/evcc
that referenced
this pull request
May 15, 2026
)" This reverts commit 726bea6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility for DSMR API v2 endpoints used by Smartstuff Ethernet P1 Dongle Pro+ devices.
Documentations
Suggested change