Add Kaco Blueplanet#30293
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- The
urivalue contains&characters and should be wrapped in quotes (e.g."http://{{ .host }}/getdevdata.cgi?device=2&sn={{ .sn }}") to avoid YAML interpreting them as anchors.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `uri` value contains `&` characters and should be wrapped in quotes (e.g. `"http://{{ .host }}/getdevdata.cgi?device=2&sn={{ .sn }}"`) to avoid YAML interpreting them as anchors.
## Individual Comments
### Comment 1
<location path="templates/definition/meter/kaco-blueplanet.yaml" line_range="15" />
<code_context>
+ description:
+ en: The serial number of the inverter to query
+ de: Die Seriennummer des Kaco-Wechselrichters
+ example: 8.0NX312001234Expand commentComment on lines R9 to R20Resolved
+render: |
+ type: custom
</code_context>
<issue_to_address>
**issue (bug_risk):** Cleanup stray text in the `sn` example value.
The `example` value for `sn` includes stray UI text (`Expand commentComment on lines R9 to R20Resolved`), which will likely break YAML parsing or produce an invalid example. This should be trimmed to just the serial number, e.g. `example: 8.0NX312001234`.
</issue_to_address>
### Comment 2
<location path="templates/definition/meter/kaco-blueplanet.yaml" line_range="15" />
<code_context>
+ description:
+ en: The serial number of the inverter to query
+ de: Die Seriennummer des Kaco-Wechselrichters
+ example: 8.0NX312001234Expand commentComment on lines R9 to R20Resolved
+render: |
+ type: custom
</code_context>
<issue_to_address>
**issue (review_instructions):** The example value for `sn` includes extraneous text, which is inconsistent with other template parameter examples and likely violates the templates/README.md conventions.
In the other templates, `example` fields only contain the example value itself (e.g. a plain serial number) and no additional prose or tooling artefacts. Here, `example: 8.0NX312001234Expand commentComment on lines R9 to R20Resolved` appears to contain leftover UI text, which will both break the intended example and likely conflict with the formatting rules in `templates/README.md`.
Please update this line to only contain the serial number (e.g. `example: 8.0NX312001234`) in the same style as comparable templates.
<details>
<summary>Review instructions:</summary>
**Path patterns:** `templates/**/*.yaml`
**Instructions:**
Verify that the changes comply to the rules defined in templates/README.md. Also check consistence (wording) with other files inside templates directory.
</details>
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
andig
reviewed
May 28, 2026
andig
reviewed
May 28, 2026
| en: The IP address of the inverter to query | ||
| de: Die IP-Adresse des Kaco-Wechselrichters | ||
| example: 192.168.0.123 | ||
| - name: sn |
Member
There was a problem hiding this comment.
use serial as in every other template, only override the example if needed
Contributor
Author
There was a problem hiding this comment.
I changed sn to serial.
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
usageparameter is defined but never used in the rendered template; either wire it into the output or remove it to avoid confusion. - Consider making the protocol configurable or at least validating/normalizing
host, sincehttp://{{ .host }}will behave oddly if users supply a value that already includes a scheme.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `usage` parameter is defined but never used in the rendered template; either wire it into the output or remove it to avoid confusion.
- Consider making the protocol configurable or at least validating/normalizing `host`, since `http://{{ .host }}` will behave oddly if users supply a value that already includes a scheme.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
andig
reviewed
May 29, 2026
Co-authored-by: andig <cpuidle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #30335
This add support for Kaco bluplanet NX via the http api.
It uses unsecure http request as the Kaco doesn't support https.