Loadpoint: update odometer on disconnect

[andig]

Fix #30225, analogous to #29350

Re-read the vehicle odometer at disconnect and persist it into the session. Many vehicles (e.g. Skoda Enyaq) only update their mileage with a delay, so the value captured at connect is often stale, while the value after a completed charge is current. The charge-stop handler resets the API cache before disconnect, so the disconnect read returns a fresh value.

• read odometer in evVehicleDisconnectHandler before the session is cleared
• the connect-time read is kept so the live UI still shows a value immediately

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• The test mutates the global serverdb.Instance without restoring it, which can cause cross-test interference; consider saving the previous value and restoring it via t.Cleanup.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The test mutates the global `serverdb.Instance` without restoring it, which can cause cross-test interference; consider saving the previous value and restoring it via `t.Cleanup`.

## Individual Comments

### Comment 1
<location path="core/loadpoint_vehicle_test.go" line_range="448-456" />
<code_context>
+	var err error
</code_context>
<issue_to_address>
**suggestion (testing):** Reset or isolate the global serverdb.Instance to prevent cross-test interference.

Assigning to the package-level `serverdb.Instance` can leak state into other tests. Please either restore it to its previous value at the end of this test (e.g., via defer) or introduce a helper that creates an isolated in-memory DB per test and resets the global afterward to avoid order-dependent test failures.

```suggestion
func TestOdometerOnDisconnect(t *testing.T) {
	prevInstance := serverdb.Instance

	dbInstance, err := serverdb.New("sqlite", ":memory:")
	require.NoError(t, err)

	serverdb.Instance = dbInstance
	defer func() {
		serverdb.Instance = prevInstance
	}()

	db, err := session.NewStore("foo", serverdb.Instance)
	require.NoError(t, err)

	ctrl := gomock.NewController(t)
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}