Loadpoint UI: assign to real circuits only#30429
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The restriction that
gridcontrolmust not be user-assignable is now enforced directly in the UI filter; consider centralizing this rule in a shared model or API layer so the constraint is not duplicated or bypassed by other consumers of the circuits list. - With
circuitOptionsnow relying on thePropertyFieldplaceholder for the empty option, double-check that all usages of this component provide a suitable placeholder so you don't end up with a select that has no way to clear the circuit assignment.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The restriction that `gridcontrol` must not be user-assignable is now enforced directly in the UI filter; consider centralizing this rule in a shared model or API layer so the constraint is not duplicated or bypassed by other consumers of the circuits list.
- With `circuitOptions` now relying on the `PropertyField` placeholder for the empty option, double-check that all usages of this component provide a suitable placeholder so you don't end up with a select that has no way to clear the circuit assignment.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #30380
replaces #30415
Remove the option to assign a loadpoint to the
gridcontrolcircuit directly.🧹 also removes redundant
unassignedand---select options