Skip to content

Loadpoint UI: assign to real circuits only#30429

Merged
andig merged 1 commit into
masterfrom
fix/gridcontrol_select
Jun 2, 2026
Merged

Loadpoint UI: assign to real circuits only#30429
andig merged 1 commit into
masterfrom
fix/gridcontrol_select

Conversation

@naltatis
Copy link
Copy Markdown
Member

@naltatis naltatis commented Jun 2, 2026

fixes #30380
replaces #30415

Remove the option to assign a loadpoint to the gridcontrol circuit directly.

🧹 also removes redundant unassigned and --- select options

@naltatis naltatis added the ux User experience/ interface label Jun 2, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The restriction that gridcontrol must not be user-assignable is now enforced directly in the UI filter; consider centralizing this rule in a shared model or API layer so the constraint is not duplicated or bypassed by other consumers of the circuits list.
  • With circuitOptions now relying on the PropertyField placeholder for the empty option, double-check that all usages of this component provide a suitable placeholder so you don't end up with a select that has no way to clear the circuit assignment.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The restriction that `gridcontrol` must not be user-assignable is now enforced directly in the UI filter; consider centralizing this rule in a shared model or API layer so the constraint is not duplicated or bypassed by other consumers of the circuits list.
- With `circuitOptions` now relying on the `PropertyField` placeholder for the empty option, double-check that all usages of this component provide a suitable placeholder so you don't end up with a select that has no way to clear the circuit assignment.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig merged commit 869ac1d into master Jun 2, 2026
13 checks passed
@andig andig deleted the fix/gridcontrol_select branch June 2, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ux User experience/ interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

circuit: not found: gridcontrol

2 participants