Speed up Playwright CI by skipping install-deps on cache hit#30503
Merged
Conversation
…runs The integration job ran `playwright install-deps chromium` (apt-get) on every cache hit, which dominated setup time. The depot ubuntu-24.04 runner already ships Chromium's library dependencies, and `--with-deps` installs them on a cache miss, so the per-run deps step is redundant. microsoft/playwright#23388 (comment)
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Member
interesting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration job ran
npx playwright install-deps chromiumon every browser-cache hit. That step runsapt-getand dominates setup time on the hot path.The
depot-ubuntu-24.04-arm-32runner already ships Chromium's library dependencies, and the cache-miss path still installs them viaplaywright install --with-deps chromium. Removing the per-run deps step makes the common cached run noticeably faster without changing behaviour.Based on microsoft/playwright#23388 (comment)