Skip to content

Battery UI: drop orphan grid charge headline on fresh installs#30530

Merged
andig merged 2 commits into
masterfrom
fix/battery_gridcharge
Jun 5, 2026
Merged

Battery UI: drop orphan grid charge headline on fresh installs#30530
andig merged 2 commits into
masterfrom
fix/battery_gridcharge

Conversation

@naltatis
Copy link
Copy Markdown
Member

@naltatis naltatis commented Jun 5, 2026

Only show grid charge if feature is available or an old values exists.

Cause: different undefined and null handling.

@naltatis naltatis requested a review from andig June 5, 2026 09:00
@naltatis naltatis added bug Something isn't working ux User experience/ interface labels Jun 5, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider moving the normalization of batteryGridChargeLimit (the new gridChargeLimit computed) closer to where the state is defined or shared (e.g., in the store or a shared helper) so that all consumers get consistent undefined/null handling without each view having to re-implement it.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider moving the normalization of `batteryGridChargeLimit` (the new `gridChargeLimit` computed) closer to where the state is defined or shared (e.g., in the store or a shared helper) so that all consumers get consistent `undefined`/`null` handling without each view having to re-implement it.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig merged commit 29e5599 into master Jun 5, 2026
7 checks passed
@andig andig deleted the fix/battery_gridcharge branch June 5, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ux User experience/ interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants