Introduce Optimizer settings#34
Merged
Merged
Conversation
Member
|
Great PR, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses PyDantic Settings to make the optimizer configurable in terms of threads and time.
By setting the environment variable
OPTIMIZER_NUM_THREADSorOPTIMIZER_TIME_LIMIT, you can set these values from the environment.After this is merged, it might make sense to run either
--num-workers 4andOPTIMIZER_NUM_THREADS=2--num-workers 8andOPTIMIZER_NUM_THREADS=1This might lead to longer times to solve the optimizations but should lead to a steady usage of at most 8 cores even under heavy load.
The default gunicorn timeout is 30 seconds, so
OPTIMIZER_TIME_LIMIT=30might make sense to set as well.