Skip to content

lint#31

Merged
fcsondheim merged 1 commit into
mainfrom
lint
Jun 1, 2026
Merged

lint#31
fcsondheim merged 1 commit into
mainfrom
lint

Conversation

@fcsondheim
Copy link
Copy Markdown
Collaborator

@fcsondheim fcsondheim commented Jun 1, 2026

What

change biome config

"formatter": {
      "quoteStyle": "single",
      "semicolons": "asNeeded"
}

Why

lint standardising

@fcsondheim fcsondheim requested review from ccp-bofai and Copilot June 1, 2026 11:27
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Coverage Report for @evefrontier/dapp-kit

Status Category Percentage Covered / Total
🔵 Lines 92.78% 489 / 527
🔵 Statements 92.85% 507 / 546
🔵 Functions 88.46% 92 / 104
🔵 Branches 79.54% 280 / 352
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/libs/dapp-kit/graphql/client.ts 76.08% 85% 33.33% 76.08% 114-117, 194-224, 272-438, 531-533
packages/libs/dapp-kit/graphql/queries.ts 100% 100% 100% 100%
packages/libs/dapp-kit/types/contexts.ts 100% 100% 100% 100%
packages/libs/dapp-kit/types/index.ts 100% 100% 100% 100%
packages/libs/dapp-kit/types/sponsoredTransaction.ts 100% 100% 100% 100%
packages/libs/dapp-kit/types/types.ts 100% 100% 100% 100%
packages/libs/dapp-kit/types/worldApiReturnTypes.ts 100% 100% 100% 100%
packages/libs/dapp-kit/utils/burnRate.ts 100% 100% 100% 100%
packages/libs/dapp-kit/utils/character.ts 93.75% 93.54% 100% 92.85% 19
packages/libs/dapp-kit/utils/characterOwnedObjects.ts 100% 100% 100% 100%
packages/libs/dapp-kit/utils/config.ts 100% 87.5% 100% 100%
packages/libs/dapp-kit/utils/constants.ts 100% 100% 100% 100%
packages/libs/dapp-kit/utils/datahub.ts 37.5% 100% 66.66% 37.5% 58-64
packages/libs/dapp-kit/utils/errors.ts 100% 100% 100% 100%
packages/libs/dapp-kit/utils/logger.ts 86.36% 68.96% 100% 86.36% 26, 75, 87, 98, 115, 120, 134, 140, 160, 165, 172, 177, 187, 196, 203, 246, 269, 272
packages/libs/dapp-kit/utils/mapping.ts 95.12% 92.85% 100% 95% 25-27
packages/libs/dapp-kit/utils/transforms.ts 100% 60.24% 100% 100%
packages/libs/dapp-kit/utils/utils.ts 100% 95.65% 100% 100%
packages/libs/dapp-kit/wallet/features.ts 100% 100% 100% 100%
packages/libs/dapp-kit/wallet/utils.ts 85.71% 100% 100% 85.71% 93
packages/libs/dapp-kit/wallet/__tests__/testHelpers.ts 75% 100% 66.66% 100% 5-8
Generated in workflow #62 for commit 6d1074a by the Vitest Coverage Report Action

Copilot AI reviewed Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes formatting across the monorepo by updating Biome’s JavaScript formatter settings (single quotes, semicolons as-needed) and applying the resulting reformatting to UI components, dapp-kit, and the assembly app.

Changes:

  • Update biome.jsonc formatter options for JavaScript/TypeScript formatting consistency.
  • Reformat a large set of TS/TSX/JS/CJS/DTS/config files to match the new formatter output.
  • Touch multiple library/app entrypoints and configs with formatting-only changes (imports, quotes, semicolons, trailing commas).

Reviewed changes

Copilot reviewed 105 out of 111 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
biome.jsonc Updates Biome JS formatter settings (single quotes, semicolons as-needed).
packages/libs/ui-components/vite.config.ts Formatting-only changes to Vite config.
packages/libs/ui-components/svg.d.ts Formatting-only changes to SVG module typings.
packages/libs/ui-components/index.ts Formatting-only changes to barrel exports.
packages/libs/ui-components/assets/index.ts Formatting-only changes to asset exports.
packages/libs/ui-components/assets/index.d.ts Formatting-only changes to PNG module typing.
packages/libs/ui-components/assets/avatar-gen/index.ts Formatting-only changes to identicon exports.
packages/libs/ui-components/modules/TurretView.tsx Formatting-only changes.
packages/libs/ui-components/modules/Offline.tsx Formatting-only changes.
packages/libs/ui-components/modules/InventoryView.tsx Formatting-only changes.
packages/libs/ui-components/modules/GateView.tsx Formatting-only changes.
packages/libs/ui-components/modules/GateCard.tsx Formatting changes; logic area reviewed (interaction gating effect).
packages/libs/ui-components/modules/skeletons/RootSkeleton.tsx Formatting-only changes.
packages/libs/ui-components/modules/skeletons/MonitorSkeleton.tsx Formatting-only changes.
packages/libs/ui-components/modules/skeletons/BehaviourSkeleton.tsx Formatting-only changes.
packages/libs/ui-components/components/Radio.tsx Formatting-only changes.
packages/libs/ui-components/components/Header.tsx Formatting-only changes.
packages/libs/ui-components/components/EveScroll.tsx Formatting-only changes.
packages/libs/ui-components/components/EveLoadingAnimation.tsx Formatting-only changes.
packages/libs/ui-components/components/EveLinearBar.tsx Formatting-only changes.
packages/libs/ui-components/components/EveLayout.tsx Formatting-only changes.
packages/libs/ui-components/components/EveInput.tsx Formatting-only changes.
packages/libs/ui-components/components/EveFeralCodeGen.tsx Formatting-only changes.
packages/libs/ui-components/components/EveContainer.tsx Formatting-only changes.
packages/libs/ui-components/components/EveConnectWallet.tsx Formatting-only changes.
packages/libs/ui-components/components/EveButtonDuo.tsx Formatting-only changes.
packages/libs/ui-components/components/EveButton.tsx Formatting-only changes.
packages/libs/ui-components/components/EveAlert.tsx Formatting-only changes.
packages/libs/ui-components/components/ErrorNotice.tsx Formatting-only changes.
packages/libs/ui-components/components/Divider.tsx Formatting-only changes.
packages/libs/ui-components/components/Console.tsx Formatting changes; security/operational implications reviewed (eval, console monkey-patch).
packages/libs/ui-components/components/ConnectWallet.tsx Formatting-only changes.
packages/libs/ui-components/components/ClickToCopy.tsx Formatting-only changes.
packages/libs/ui-components/components/AssemblyInfo.tsx Formatting-only changes.
packages/libs/dapp-kit/vitest.config.ts Formatting-only changes to Vitest config.
packages/libs/dapp-kit/vite-env.d.ts Formatting-only changes to Vite env typings.
packages/libs/dapp-kit/index.ts Formatting-only changes to package entrypoint exports.
packages/libs/dapp-kit/config/index.ts Formatting-only changes to config barrel export.
packages/libs/dapp-kit/config/dapp-kit.ts Formatting-only changes to dapp-kit config.
packages/libs/dapp-kit/graphql/queries.ts Formatting-only changes to GraphQL query strings.
packages/libs/dapp-kit/graphql/index.ts Formatting-only changes to GraphQL barrel exports.
packages/libs/dapp-kit/graphql/client.ts Formatting-only changes to GraphQL client utilities.
packages/libs/dapp-kit/hooks/useSponsoredTransaction.ts Formatting-only changes.
packages/libs/dapp-kit/hooks/useSmartObject.ts Formatting-only changes.
packages/libs/dapp-kit/hooks/useNotification.ts Formatting-only changes.
packages/libs/dapp-kit/hooks/useConnection.ts Formatting-only changes.
packages/libs/dapp-kit/hooks/index.ts Formatting-only changes to hooks barrel exports.
packages/libs/dapp-kit/providers/EveFrontierProvider.tsx Formatting-only changes.
packages/libs/dapp-kit/providers/VaultProvider.tsx Formatting-only changes.
packages/libs/dapp-kit/providers/NotificationProvider.tsx Formatting-only changes.
packages/libs/dapp-kit/providers/index.ts Formatting-only changes to providers barrel exports.
packages/libs/dapp-kit/utils/index.ts Formatting-only changes to utils barrel exports.
packages/libs/dapp-kit/utils/utils.ts Formatting-only changes to general utilities.
packages/libs/dapp-kit/utils/mapping.ts Formatting-only changes to mapping utilities.
packages/libs/dapp-kit/utils/errors.ts Formatting-only changes to error utilities.
packages/libs/dapp-kit/utils/datahub.ts Formatting-only changes to datahub utilities.
packages/libs/dapp-kit/utils/config.ts Formatting-only changes to config utilities.
packages/libs/dapp-kit/utils/characterOwnedObjects.ts Formatting-only changes.
packages/libs/dapp-kit/utils/character.ts Formatting-only changes.
packages/libs/dapp-kit/utils/burnRate.ts Formatting-only changes.
packages/libs/dapp-kit/utils/tests/logger.test.ts Formatting-only changes to tests.
packages/libs/dapp-kit/utils/tests/datahub.test.ts Formatting-only changes to tests.
packages/libs/dapp-kit/utils/tests/constants.test.ts Formatting-only changes to tests.
packages/libs/dapp-kit/utils/tests/character.test.ts Formatting-only changes to tests.
packages/libs/dapp-kit/types/index.ts Formatting-only changes to types barrel exports.
packages/libs/dapp-kit/types/types.ts Formatting-only changes to shared types.
packages/libs/dapp-kit/types/worldApiReturnTypes.ts Formatting-only changes to API return types.
packages/libs/dapp-kit/types/sponsoredTransaction.ts Formatting-only changes to sponsored tx types.
packages/libs/dapp-kit/types/contexts.ts Formatting-only changes to context types.
packages/libs/dapp-kit/types/character.ts Formatting-only changes to character JSON types.
packages/libs/dapp-kit/types/global.d.ts Formatting-only changes to module augmentation.
packages/libs/dapp-kit/wallet/index.ts Formatting-only changes to wallet barrel exports.
packages/libs/dapp-kit/wallet/utils.ts Formatting-only changes to wallet utilities.
packages/libs/dapp-kit/wallet/features.ts Formatting-only changes to wallet feature types/guards.
packages/libs/dapp-kit/wallet/tests/utils.test.ts Formatting-only changes to tests.
packages/libs/dapp-kit/wallet/tests/features.test.ts Formatting-only changes to tests.
packages/libs/dapp-kit/wallet/tests/testHelpers.ts Formatting-only changes to tests.
packages/libs/dapp-kit/scripts/fix-esm-extensions.cjs Formatting-only changes to build helper script.
packages/apps/assembly/vite.config.ts Formatting-only changes to app Vite config.
packages/apps/assembly/vite-env.d.ts Formatting-only changes to app env typings.
packages/apps/assembly/tailwind.config.js Formatting-only changes to Tailwind config.
packages/apps/assembly/postcss.config.js Formatting-only changes to PostCSS config.
packages/apps/assembly/src/vite-env.d.ts Formatting-only changes to SVG module typings.
packages/apps/assembly/src/main.tsx Formatting-only changes to app bootstrap.
packages/apps/assembly/src/App.tsx Formatting-only changes to app root component.
packages/apps/assembly/src/components/views/RootView.tsx Formatting-only changes.
packages/apps/assembly/src/components/views/Root.tsx Formatting-only changes.
packages/apps/assembly/src/components/views/Overview.tsx Formatting-only changes.
packages/apps/assembly/src/components/views/BehaviourView.tsx Formatting-only changes.
packages/apps/assembly/src/components/skeletons/SkeletonConnect.tsx Formatting-only changes.
packages/apps/assembly/src/components/EditUnit.tsx Formatting-only changes.
packages/apps/assembly/src/components/Behaviour.tsx Formatting-only changes.
packages/apps/assembly/src/components/AssemblyIcon.tsx Formatting-only changes.
packages/apps/assembly/src/components/Actions.tsx Formatting-only changes.
packages/apps/assembly/src/functions/bringOnline.ts Formatting-only changes.
packages/apps/assembly/src/functions/bringOffline.ts Formatting-only changes.

Comment thread packages/libs/ui-components/modules/GateCard.tsx
Comment thread packages/libs/ui-components/components/Console.tsx
Comment thread packages/libs/ui-components/components/Console.tsx
ccp-bofai
ccp-bofai approved these changes Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown

@ccp-bofai ccp-bofai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcsondheim fcsondheim merged commit cd94d2a into main Jun 1, 2026
4 checks passed
@fcsondheim fcsondheim deleted the lint branch June 1, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ccp-bofai ccp-bofai ccp-bofai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fcsondheim @ccp-bofai