Conversation
|
Thanks for contributing @kbudde! I will review this PR in the next couple of days 👍 |
| USER nobody:nobody | ||
|
|
||
| # Run the compiled binary. | ||
| ENTRYPOINT ["/app"] No newline at end of file |
There was a problem hiding this comment.
(nitpick) Missing trailing newline
|
|
||
| // Try to read config | ||
| if err := viper.ReadInConfig(); err != nil { | ||
| PrintErrorAndExit(err) |
There was a problem hiding this comment.
Why was this change introduced? My thought was to fail as early as possible. However, I see that your message is better.
|
Every option should be configurable via flags, with the exception of DNS provider credentials. As far as I know most of the providers (if not all) only support supplying secrets via environment variables (and recently a file on disk as well). This support is provided by the lego library. I've opened an issue on providing configuration via environment variables, since that is not currently supported (but it ought to be). The Dockerfile looks good, I've left a few comments. You can respond to them if you'll want to, but it can be merged in it's current state as well without problems. Thanks again! |
|
Sorry, I messed up while applying some fixes. Anyhow, it's now on master 👍. Thanks again! |
Hi,
I've created a basic dockerfile for building and running intercert (#28 ).
I've made the configuration file optional to be able to start intercert without config file. Is it possible to configure everything through flags?
More elegant in docker world would be a configuration through environment variables.
You can build it with.
and run the containter with
or
Currently I'm not using intercert. So it's just wild guessing if it will working or not. This PR is just a first starting point.