Skip to content

[WIP] Certificate renewal#3

Merged
evenh merged 8 commits intomasterfrom
certificate-renewal
Apr 27, 2019
Merged

[WIP] Certificate renewal#3
evenh merged 8 commits intomasterfrom
certificate-renewal

Conversation

@evenh
Copy link
Copy Markdown
Owner

@evenh evenh commented Jan 11, 2019

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 11, 2019

Codecov Report

Merging #3 into master will decrease coverage by 4.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   16.23%   12.17%   -4.06%     
==========================================
  Files           4        4              
  Lines         117      156      +39     
==========================================
  Hits           19       19              
- Misses         98      137      +39
Impacted Files Coverage Δ
server/issuer.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c163d...b9aab2f. Read the comment docs.

Repository owner deleted a comment from codecov Bot Jan 11, 2019
@evenh evenh force-pushed the certificate-renewal branch from b9aab2f to 33ba2cf Compare January 25, 2019 08:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 25, 2019 •
edited
Loading

Codecov Report

Merging #3 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   15.96%   15.83%   -0.14%     
==========================================
  Files           3        3              
  Lines         119      120       +1     
==========================================
  Hits           19       19              
- Misses        100      101       +1
Impacted Files Coverage Δ
server/issuer.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef117f...6cc608b. Read the comment docs.

@evenh evenh force-pushed the certificate-renewal branch from a2b97e1 to 34f55ad Compare February 22, 2019 08:47
@evenh evenh force-pushed the certificate-renewal branch 2 times, most recently from 081fe43 to 15e9a3a Compare March 10, 2019 19:07
@evenh evenh force-pushed the certificate-renewal branch 2 times, most recently from b527caa to 13c3391 Compare April 26, 2019 13:17
@evenh evenh force-pushed the certificate-renewal branch from 13c3391 to a2b0a27 Compare April 26, 2019 21:35
ghost
ghost reviewed Apr 26, 2019
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

@evenh evenh force-pushed the certificate-renewal branch from a2b0a27 to 6cc608b Compare April 26, 2019 21:37
ghost
ghost reviewed Apr 27, 2019
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

@evenh evenh force-pushed the certificate-renewal branch from 02bea02 to 3a206d8 Compare April 27, 2019 12:16
@evenh evenh merged commit 89b1fc6 into master Apr 27, 2019
@evenh evenh deleted the certificate-renewal branch April 27, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@evenh