-
Notifications
You must be signed in to change notification settings - Fork 5
Pixelwise velocity #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ency + eros-framer
example/movenet/eros-framer.cpp @francodipietro - I'm not sure about the changes here. why not keep the original eros implementation? I think this was some attempt to combine EROS within the single app but something seems to have gone wrong. are you using the pw-velocity? it seems that it hasn't changed much since I wrote this part. I thought you would have updated it. Is the algorithm you are using in a different location? |
I honestly don't remember why this was changed in the first place, but could be what you mention. In any case, we need to check that changing it back does not affect in any aspect the performance of the pipeline, as this is the was it's been working for a while. I completely agree it's not nice to use the eros implementation from the motion_estimation file, for sure. I'll check on this.
Yes, I am using it. It wasn't working at all before, and now it is. The parts that are not there like including the circle and so on, it's just because it didn't make any sense to waste time in testing again stuff that did no work with the O(ev) implementation. |
This branch includes the O(px) implementation as well as some other bug fixes.