Merged
Conversation
MidnightDesign
approved these changes
Dec 7, 2023
Co-authored-by: Rudolph Gottesheim <r.gottesheim@midnight-design.at>
Co-authored-by: Rudolph Gottesheim <r.gottesheim@midnight-design.at>
…r to use color=inherit in children
Contributor
Author
|
@MidnightDesign Moved the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened?
fontWeightadded > default = "bold"; defined as a string to handle normal values of font-weight CSSPropertytested on:
I didn't place the badge directly on the corner of the volume, as otherwise it would look very squashed on my seatmap "A (Grandstand NORD HKR 2022 departure volumes)", for example.
Seatmap Story
I wasn't sure whether the gray boxes were still needed for the rotated volumes in the seatmap story - I removed them for the moment.
I wasn't sure why the
complex-example-referencewas there - I updated it as well and left the original in the repo for now. Would be cool if we could clarify what the picture is there for and whether it can be removed.Screenshots Shop
Adjustments have no effect on other seatmaps
Screenshots Storybook
Seatmap Story
Volume/Badge Stories