Skip to content

Conversation

@glensc
Copy link
Member

@glensc glensc commented Sep 10, 2017

currently usage was taken from old cli app:

➔ ./eventum.php wr --help
Help:

  ./eventum.php weekly-report [<week>] [--separate-closed]
  ./eventum.php weekly-report [<start>] [<end>] [--separate-closed]

  Fetches the weekly report. Week is specified as an integer with 0 representing
  the current week, -1 the previous week and so on. If the week is omitted it
  defaults to the current week. Alternately, a date range can be set. Dates
  should be in the format 'YYYY-MM-DD'.

it's not very intuitive and not easy to process such commandline arguments.

so none of that is implemented: src/Command/WeeklyReportCommand.php:74-77

should propose interface using arguments or options.

@glensc
Copy link
Member Author

glensc commented Sep 10, 2017

@balsdorf propose something :)

@glensc glensc closed this Sep 10, 2017
@glensc glensc reopened this Sep 10, 2017
@balsdorf
Copy link

Are you saying this is hard to implement or hard to use?

The only simplification I would say is remove the relative week from the default argument and add it as ---relative-week=X

So:

./eventum.php weekly-report [<start>] [<end>] [--separate-closed] [--relative-week=X]

Seems simple enough

@glensc glensc changed the title WIP: usable weekly-report arguments usable weekly-report arguments Sep 17, 2017
@glensc glensc changed the title usable weekly-report arguments implement date arguments for weekly-report Sep 17, 2017
@glensc
Copy link
Member Author

glensc commented Sep 17, 2017

decided to drop week support. current code is too complex to understand what it does. so just dropped it.

you may implement it yourself if that functionality is required.

@glensc glensc merged commit 2be186d into master Sep 17, 2017
@glensc glensc deleted the weekly-report-arguments branch September 17, 2017 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants