[Feat]: Show input borders only in edit mode -issue(#3736)

[AnicetFantomas]

Description

• When a user updates their personal information, they should be able to distinguish between editing their details and simply viewing the information they have already provided.

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation update

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented on my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

Previous screenshots

Please add here videos or images of the previous status

Updates

Screencast.from.2025-04-08.12-17-02.webm

Summary by CodeRabbit

• Style
  • Improved layout formatting on the personal settings page for a more consistent user experience.
• Refactor
  • Enhanced the display logic for personal input fields in the settings form for clearer visual presentation.
• Chore
  • Organized dependency management by reordering items and removing an unused image processing dependency.

[CLAassistant]

All committers have signed the CLA.

[greptile-apps]

PR Summary

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: https://app.greptile.com/review/github.

_{💡 (4/5) You can add custom instructions or style guidelines for the bot here!}

_{4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request makes formatting and refactoring updates in the personal settings components and adjusts dependency management in the package files. The Personal component’s indentation in page.tsx is standardized, while the PersonalSettingForm refactors conditional rendering by introducing a helper function (displayValueField) and making minor styling adjustments. Additionally, dependency orders have been updated in the root package.json and cross-env removed, with the sharp dependency being removed from the web package file. No functional or control flow changes were introduced.

Changes

File(s)	Change Summary
apps/web/app/[…]/page.tsx	Adjusted code indentation in the Personal component; standardized spacing (tabs replaced with spaces) for consistent formatting.
apps/web/lib/[…]/personal-setting-form.tsx	Refactored JSX rendering by introducing a helper function (displayValueField) to handle input field display; minor styling adjustments and state initialization formatting.
package.json, apps/web/package.json	Reordered dependencies in the root package file and removed "cross-env" from devDependencies; removed the "sharp" dependency from the web package file.

Suggested reviewers

• evereq
• Innocent-Akim
• NdekoCode

Poem

I'm just a rabbit dancing in the code,
Hop along with changes, on a bouncy road!
Indents aligned, logic refined,
Dependencies spruced up, bugs left behind.
🐇 Hooray for a cleaner, brighter node!

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[socket-security]

Report too large to display inline

View full report↗︎

[evereq]

Hm, I HATE this UI / UX, no idea how you guys like it when no border initially shown, but text feels like just there in the air etc. Can we have default border all time, but in edit mode maybe make bolder color to change to something more "dark" or something, not sure, but whatever you try to come up here in UX / UI don't feel right to me

[AnicetFantomas]

Hm, I HATE this UI / UX, no idea how you guys like it when no border initially shown, but text feels like just there in the air etc. Can we have default border all time, but in edit mode maybe make bolder color to change to something more "dark" or something, not sure, but whatever you try to come up here in UX / UI don't feel right to me

Sure, let me find a fair solution here.

[AnicetFantomas]

Hey @evereq, I've made a small change on the border, not much but enough to see the difference between the edit mode and the view informations mode.