Skip to content

fix(site): restore team avatar framing#59

Merged
Glazlk merged 1 commit into
mainfrom
fix/team-avatar-layout
May 30, 2026
Merged

fix(site): restore team avatar framing#59
Glazlk merged 1 commit into
mainfrom
fix/team-avatar-layout

Conversation

@ilyar
Copy link
Copy Markdown
Contributor

@ilyar ilyar commented May 30, 2026

Summary

  • keep team photo frames square after explicit avatar dimensions were added
  • update visual baselines for the repaired team/contact viewports
  • add an acceptance assertion that avatar frames and images stay square

Why this happened

The previous visual baselines had been regenerated after adding avatar width/height attributes, but the CSS did not constrain the image height inside the card. The screenshot tests then approved that broken state, so later acceptance runs compared against the broken screenshots. This PR adds a geometry assertion so a broken photo frame cannot be accepted just by refreshing PNG baselines.

Validation

  • npm run lint
  • npm run acceptance:test
  • npm run lighthouse

@ilyar ilyar requested a review from Glazlk May 30, 2026 01:11
Copy link
Copy Markdown
Contributor

@Glazlk Glazlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: correct fix for the team avatar framing regression. Moving aspect-ratio to .team__photo (container) with overflow:hidden and width/height:100% + object-fit:cover on the image is more robust than aspect-ratio on the img. The geometry assertion (square frame + image fills frame) is a solid regression guard against PNG-only approvals. CI green (lint, build, acceptance incl. new assertion, lighthouse). LGTM.

@Glazlk Glazlk merged commit 6e8ae85 into main May 30, 2026
4 checks passed
@Glazlk Glazlk deleted the fix/team-avatar-layout branch May 30, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants