fix(site): restore team avatar framing#59
Merged
Merged
Conversation
Glazlk
approved these changes
May 30, 2026
Contributor
Glazlk
left a comment
There was a problem hiding this comment.
Reviewed: correct fix for the team avatar framing regression. Moving aspect-ratio to .team__photo (container) with overflow:hidden and width/height:100% + object-fit:cover on the image is more robust than aspect-ratio on the img. The geometry assertion (square frame + image fills frame) is a solid regression guard against PNG-only approvals. CI green (lint, build, acceptance incl. new assertion, lighthouse). LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this happened
The previous visual baselines had been regenerated after adding avatar
width/heightattributes, but the CSS did not constrain the image height inside the card. The screenshot tests then approved that broken state, so later acceptance runs compared against the broken screenshots. This PR adds a geometry assertion so a broken photo frame cannot be accepted just by refreshing PNG baselines.Validation