fix: update SSM parameter handling and make certain fields optional in configuration#597
Merged
liu-zhipeng merged 1 commit intostagingfrom Mar 13, 2026
Merged
fix: update SSM parameter handling and make certain fields optional in configuration#597liu-zhipeng merged 1 commit intostagingfrom
liu-zhipeng merged 1 commit intostagingfrom
Conversation
liu-zhipeng
approved these changes
Mar 13, 2026
jintukumardas
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three compounding bugs:
Double SSM reads: config.ts reads Share 1 from SSM in a first loop (lines 233-275), then stitchConfig reads the exact same parameters from SSM again (stitcher.ts line 175). The first loop's results are ignored by the stitcher.
Expensive API pattern: getSsmParameter called DescribeParameters + GetParameter per field = 2 API calls per field. With 4 fields x 2 reads x 2 calls = 16 SSM API calls per Lambda invocation. With 6 Lambdas on overlapping schedules: up to 96 concurrent SSM calls, easily exceeding the DescribeParameters limit of ~10 TPS in sa-east-1.
Error swallowing: getSsmParameter caught ThrottlingException and returned undefined, which downstream code treated as "parameter not found" -- a misleading error message hiding the real cause.