makeInteractive Crash fix when NSRange.location == NSNotFound#28
Merged
evermeer merged 1 commit intoevermeer:masterfrom Dec 23, 2018
HaysSoftware:feature/SkipRangeNotFound
Merged
makeInteractive Crash fix when NSRange.location == NSNotFound#28evermeer merged 1 commit intoevermeer:masterfrom HaysSoftware:feature/SkipRangeNotFound
evermeer merged 1 commit intoevermeer:masterfrom
HaysSoftware:feature/SkipRangeNotFound
Conversation
…d a link. This would crash previously.
Owner
|
Thanks! I do have one question. Why are you using: |
Contributor
Author
|
Mainly just personal preference. To me, it reads better. If I use an “if” statement, I typically expect the body to do something. The guard is then just used more as an assert. Both accomplish the same thing in this case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the range location can't be found, return without attempting to add a link. This would crash previously.