feat: add native PDF reader toggle and DIVINA fallback#485
Merged
Conversation
Add a Use Native PDF Reader preference defaulting to true and hide PDF-native options when disabled. Route PDF books through DivinaReaderView when the toggle is off so PDFs follow DIVINA behavior. Add localized strings in all supported languages for the new toggle and explanatory note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use Native PDF Readersetting (defaulttrue) in PDF preferences.DivinaReaderViewwhen native PDF reader is disabled.misc/translate.py.Related Issue
Testing
make formatmake build-macos./misc/translate.py list(no missing translations)