fix: prevent UIPageViewController page curl crashes#498
Merged
Conversation
Harden CurlPageView navigation by tracking active transitions and synchronizing the visible page index before handling gestures or programmatic navigation. Remove cross-key controller reuse in WebPubPageView so each cache key maps to a stable view controller instance, avoiding invalid transition payloads in UIPageViewController.
Reintroduce cross-key controller reuse for WebPubPageView to avoid full WebView recreation on each page turn. Protect reuse safety by reserving controllers returned by data source callbacks and excluding visible, pending, and reserved controllers from reuse and eviction to prevent invalid UIPageViewController transition payloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CurlPageViewtransition safety by tracking active page-curl transitions and syncingcurrentPageIndexfrom the visible controller before gesture and target navigation checksWebPubPageViewcontroller reuse for smooth page turns, but add strict reuse guards (visible + pending + reserved) so controllers returned bybefore/afterare not repurposed during the same transitionRelated Issue
Testing
make build-ios