fix: stabilize book card grid alignment#518
Merged
Conversation
Reserve a fixed progress-bar slot in book cards so cards keep the same height when some books have in-progress state and others do not. Adjust content spacing to 2 when progress bars are enabled to keep tighter vertical rhythm. Remove accessibilityHidden from the placeholder bar per review feedback.
Pass through real progress to ReadingProgressBar and control visibility only with opacity for the reserved progress slot behavior. Include the existing Swift format-only changes in ThumbnailCache.swift.
Remove intermediate visibility properties and keep the reserved progress slot logic directly in the view body. This keeps behavior unchanged while making intent easier to read.
Group progress bar and metadata text under a shared non-overlay branch. Keep cover-only behavior unchanged while making progress-bar condition simpler.
This reverts commit cabc206.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
make build-macos