Conversation
Replace handwritten SQLite3 operations in LogStore with SQLiteData table/select models and structured query DSL. Add nonisolated table model declarations for Swift 6 default MainActor isolation compatibility. Switch migration to reset_logs_v2 that drops and recreates logs schema without preserving existing log rows, and add migration/cleanup debug prints to diagnose unexpected log clearing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlite-dataas a Swift package dependency for the app target.LogStorefrom handwrittenSQLite3statements toSQLiteDatatable/query models.reset_logs_v2migration that drops and recreates the logs table (no legacy log data preservation).Testing
make formatmake build-macosmake build(fails in this environment due to SwiftSyntax prebuilt module SDK mismatch in package macros)