refactor(reader): centralize render config and harden hosting env#535
Merged
refactor(reader): centralize render config and harden hosting env#535
Conversation
Add ReaderRenderConfig and pass it through Divina, scroll/curl page views, and webtoon readers to remove duplicated AppStorage reads in leaf views. Ensure UIHostingController pages explicitly receive readerPresentation and readerBackground environment values so nested hosting roots do not crash when environment objects are missing. Also remove unused environment dependencies discovered during crash triage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ReaderRenderConfigas the single render preference payload for DIVINA/Webtoon page renderingrenderConfigthroughDivinaReaderView,ScrollPageView,CurlPageView, page image views, and Webtoon readers@AppStoragereads and use passed config values for tap zones, page numbers, background, live text, and double-tap zoomreaderPresentationandreaderBackgroundPreferenceintoUIHostingControllerpages created inside curl modeWhy
Crash logs pointed to missing object-style environment values inside nested hosting roots. The reader stack also had split configuration sources (
@AppStorage,AppConfig, params), which made behavior inconsistent and harder to reason about.Validation
make build-iosmake build-macosmake build-tvos