fix: reopen completed books from beginning#537
Merged
Conversation
When opening a completed book, skip resume-page restoration and start from the beginning for both Divina and PDF readers. Reset page and target indices before loading pages so stale reader state cannot carry over between openings. Also remove ImageAnalysisInteraction during iOS page teardown to avoid lingering tracking warnings after closing the reader.
Skip restoring saved EPUB progression when the book progress is already marked completed. Apply the same resume decision when delayed reload happens after background download completion so completed books still open at the beginning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageAnalysisInteractionduring iOS page teardown to avoid post-close tracking warnings.Testing
make buildmake build-ios