refactor: reader page id groundwork for seamless chapter transitions#553
Merged
refactor: reader page id groundwork for seamless chapter transitions#553
Conversation
Introduce ReaderPage/ReaderPageID and migrate reader caches and view items to stable page identifiers. Remove EndPage action buttons so end screens act as display-only pages in the paging flow. Update reader views to resolve page indices from ReaderPageID and use the new preloaded image accessors. Add AGENTS.md guidance to allow SwiftUI->UIKit/AppKit but disallow UIKit/AppKit->SwiftUI hosting for feature UI because hosting controllers do not inherit required SwiftUI environment values. This is part of issue #539 and lays groundwork for seamless chapter transitions across DIVINA modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReaderPageIDandReaderPageas stable reader-level page identity.ReaderViewModelcaches/state (preloaded images, animated states, download/upscale tasks) to key byReaderPageID.ReaderViewItemfrom index-based payloads toReaderPageIDpayloads, and resolve indices via view model mapping.SwiftUI -> UIKit/AppKit, disallowUIKit/AppKit -> SwiftUIhosting for feature UI (UIHostingController/NSHostingController).Related Issue
Testing
make build