refactor: remove object environment dependencies#614
Merged
Conversation
Pass auth and reader dependencies explicitly through root context and navigation entry points. Replace the separate reader window state with a single ReaderSession source, introduce ReaderActions for leaf reader entry points, and update AGENTS guidance to ban non-optional object-style environment dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Summary
AppViewContext, tab roots, split roots, and onboarding flowsCurrentandAppStorage, keepAuthViewModelfocused on bootstrap and auth flows, and make root readiness depend on explicit bootstrap state instead of implicit environment wiringReaderWindowManagerandBookReaderStatewith a singleReaderSessionsource insideReaderPresentationManager, so iOS/tvOS overlays and the macOS reader window all read the same session stateReaderActionsfor leaf reader entry points so book cards, book actions, and series actions depend on explicit read actions instead of the whole presentation coordinatorAGENTS.mdguidance to ban non-optional object-style environment dependencies in app codeTesting
make formatmake build