Conversation
Replace runtime bundle lookups for Komga ERR_#### codes with static localized string references so Xcode string extraction keeps these entries active. This preserves the existing runtime replacement behavior while allowing make localize to stop marking the translations as stale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundle.main.localizedString(forKey:)lookups for KomgaERR_####media comments with staticString(localized:)references so Xcode string extraction keeps these entries activeCURRENT_PROJECT_VERSIONfrom 347 to 348Testing
make buildmake localize./misc/translate.py list