Skip to content

fix: repair animated playback in scroll reader#633

Merged
everpcpc merged 1 commit intomainfrom
codex/fix-scroll-animated-reader
Mar 8, 2026
Merged

fix: repair animated playback in scroll reader#633
everpcpc merged 1 commit intomainfrom
codex/fix-scroll-animated-reader

Conversation

@everpcpc
Copy link
Copy Markdown
Owner

@everpcpc everpcpc commented Mar 8, 2026

Problem

Animated image pages in the scroll reader could behave inconsistently. Tap-based navigation would start inline playback, but drag-based page changes only updated the committed item and left visible page views on a stale playback state. The temporary animated poster path also bypassed the normal fitted image presentation, so placeholders could render with the wrong geometry before playback began.

Approach

Route playback state changes through the same native page reconfiguration path used for normal page rendering, instead of mutating only the animated source URL on existing views. Keep the static fitted image view visible as the poster placeholder while the animated layer starts, so the placeholder continues to inherit the established fit layout.

Scope

  • Reconfigure native paged cells on playback activation changes for iOS and macOS scroll reader implementations
  • Remove the separate poster layer-copy path in native page items and simplify the animated presentation helper
  • Delete unused focused animated playback state and related no-op calls from the reader view model flow

Validation

  • make format
  • make build-macos
  • make build-ios
  • make build-tvos

Reconfigure visible native page items when playback focus changes so tap and drag navigation use the same animated playback path.

Keep the static image view visible as the animated poster placeholder so inline animation respects the existing fit geometry, and remove unused focused-playback state left behind in the view model.
@everpcpc everpcpc merged commit ca984e3 into main Mar 8, 2026
3 checks passed
@everpcpc everpcpc deleted the codex/fix-scroll-animated-reader branch March 8, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant