fix: repair animated playback in scroll reader#633
Merged
Conversation
Reconfigure visible native page items when playback focus changes so tap and drag navigation use the same animated playback path. Keep the static image view visible as the animated poster placeholder so inline animation respects the existing fit geometry, and remove unused focused-playback state left behind in the view model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Animated image pages in the scroll reader could behave inconsistently. Tap-based navigation would start inline playback, but drag-based page changes only updated the committed item and left visible page views on a stale playback state. The temporary animated poster path also bypassed the normal fitted image presentation, so placeholders could render with the wrong geometry before playback began.
Approach
Route playback state changes through the same native page reconfiguration path used for normal page rendering, instead of mutating only the animated source URL on existing views. Keep the static fitted image view visible as the poster placeholder while the animated layer starts, so the placeholder continues to inherit the established fit layout.
Scope
Validation
make formatmake build-macosmake build-iosmake build-tvos