fix(reader): correct the wide image logic again#640
Conversation
dyphire
changed the title
dyphire
force-pushed
the
reader
branch
2 times, most recently
from
f1250fd to
0bdfad9
Compare
|
Thanks but there are more changes needed. Please check #641 if it match your needs. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9e4cc8237
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| allowDualPairs: isActuallyUsingDualPageMode, | ||
| forceDualPairs: forceDualPagePairs, | ||
| splitWidePages: effectiveSplitWidePages, | ||
| pageCurl: AppConfig.pageTransitionStyle == .pageCurl, |
There was a problem hiding this comment.
regenerateViewState() now makes viewItems depend on AppConfig.pageTransitionStyle == .pageCurl, but there is no corresponding update path when users change “Page Transition Style” in the reader settings (DivinaReaderView only calls updateDualPageSettings, updatePageLayout, and updateSplitWidePageMode on change). As a result, switching between non-curl and page-curl mid-session can leave wide-page items in the old layout until some unrelated regeneration happens, so the displayed split behavior no longer matches the active transition style.
Useful? React with 👍 / 👎.
dyphire
force-pushed
the
reader
branch
3 times, most recently
from
47b4616 to
b29b1bc
Compare
|
I'm kind of confused about this compiler error. |
|
|
Ah, stupid mistake. Fix. |
2 participants
The limitation of hiding the split wide page option in double page mode is no longer necessary, it already works in this mode.