Merged
Conversation
Add a persisted reader preference to disable page shadows for seamless dual-page spreads. Wire the flag through reader render config and the iOS/macOS page rendering paths, rename the page-number toggle copy, and keep localization plus formatter output in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dual-page spreads in Cover and Scroll modes always rendered page shadows, which introduced a visible seam and broke seamless stitched pages. The page-number toggle copy also read more strongly than necessary.
Approach
Add a persisted
showPageShadowreader preference that defaults to enabled, expose it in both the DIVINA defaults and the in-reader settings, and thread the flag throughReaderRenderConfiginto the iOS/macOS native page rendering paths so shadow opacity and shadow paths are disabled consistently when the option is turned off.Scope
Always Show Page NumbertoShow Page NumberValidation
make formatmake buildmake localize./misc/translate.py listCloses #642