Merged
Conversation
Use the native scroll container bounds as the paging viewport in scroll mode. This keeps page sizing and content offsets aligned when the reader ignores safe areas, fixing vertical and landscape scroll drift in the Divina reader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #643 reports that Divina
Scrollmode does not stay aligned to the visible screen bounds. In practice the paging distance drifts in vertical mode and in landscape horizontal scrolling because the page viewport size can differ from the actual scroll container size once the reader extends into ignored safe areas.Approach
Use the native scroll container's visible bounds as the paging viewport instead of relying on the outer SwiftUI geometry size. On iOS/tvOS the reader now sizes pages from
UICollectionView.bounds; on macOS it usesNSScrollView.contentView.boundsso the page size tracks the visible clip view rather than the expanded document view.Scope
Validation
make formatmake build