fix: refine live text tap handling in reader#661
Merged
Conversation
Keep reader paging enabled while Live Text is on and narrow the tap-zone filter to real ImageAnalysisInteraction hit points. This prevents center control toggles from conflicting with Live Text content without blocking page-turn taps after analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With Live Text enabled in the DIVINA reader, taps could compete between VisionKit and the reader tap-zone bridge. That made center control toggles unstable and could regress into unexpected page movement in scroll mode.
Approach
Keep paging gestures enabled and tighten the iOS tap-zone filter so it only yields the center toggle when the tap actually hits an active
ImageAnalysisInteractionpoint. This avoids broad VisionKit view heuristics that could block page-turn taps after analysis.Scope
ImageAnalysisInteractionhit testing in the iOS tap bridge.Validation
make formatmake build-ios