fix: preserve current page across reader state regeneration#664
Merged
fix: preserve current page across reader state regeneration#664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reader state regeneration could overwrite the actual current page with the primary page ID of the resolved view item. When the current item was a dual-page item, that collapsed the position back to the first page of the pair and could cause restore/navigation to drift away from the page the user was actually on.
Approach
Preserve the preferred current page whenever it still belongs to the resolved view item, and only fall back to the item's primary page ID when needed.
Scope
Validation
make formatmake build-ios