fix: stabilize divina scroll navigation#667
Merged
Conversation
Prevent stale programmatic scroll state from trapping DIVINA scroll mode after tap-zone page turns. Track active programmatic targets during queued reloads, cancel navigation cleanly when swipe takes over, and keep viewport restoration from snapping back to outdated anchors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DIVINA scroll mode could get into a bad navigation state after fast tap-zone page turns. If programmatic page turns were interrupted or followed by a swipe, the reader could keep stale scroll targets alive, making page turns stall and increasing the chance of jumping back when the view refreshed.
Approach
Treat the active programmatic page turn as first-class reader state instead of inferring it from the last committed item. Queued reloads now prefer the active target, user drags explicitly cancel stale programmatic navigation, and the scroll coordinator only settles a programmatic turn once the target offset is actually reached.
Scope
ScrollReaderEnginetarget tracking for queued reloadsCURRENT_PROJECT_VERSIONto 368Validation
make formatmake build-ios