fix(reader): restore EPUB dark link semantics#676
Merged
Conversation
Align the dark-theme EPUB color override with the old Readium v1 behavior by keeping body text forced to the theme color while restoring dedicated link and visited-link colors. Add the missing Readium user color properties to the shared payload so all EPUB presentation modes pick up the same dark-mode behavior. Related #673.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The EPUB reader still regressed in dark mode after the Readium CSS v2 migration. Publication-provided dark text could leak through again, and the app-side override flattened links into the body color instead of preserving the older night-mode link treatment.
Approach
Restore the old dark-mode semantics in the shared EPUB payload so every presentation mode uses the same rules. Dark themes now force body text and background colors, keep non-link content inheriting the theme text color, and restore dedicated link and visited-link colors that match the previous Readium v1 behavior.
Scope
Validation
make formatmake buildRelated #673