fix: localize network settings timeout options#677
Merged
Conversation
Replace dynamically constructed network settings localization keys with static LocalizedStringResource values so Xcode string extraction can discover them. Add translations for the request, download, and authentication timeout rows in Localizable.xcstrings and sync the catalog after a full build. This also carries forward the current stale-string cleanup for the removed "Always Show Page Number" entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Network section in Settings showed untranslated timeout option text because
SettingsNetworkViewbuilt localization keys dynamically, so Xcode string extraction did not keep the timeout entries inLocalizable.xcstringsin sync.Approach
Replace the dynamic string-key plumbing with static
LocalizedStringResourcearguments intimeoutRow, so the timeout labels and descriptions are visible to the localization pipeline. Then add the missing request, download, and authentication timeout translations and resync the string catalog after a full build.Scope
SettingsNetworkViewLocalizable.xcstringsAlways Show Page NumberentryValidation
make buildmake localize./misc/translate.py list