fix: restore safe area after closing reader on iPad#681
Merged
Conversation
Move reader status bar ownership to ReaderOverlay so fullScreenCover and status bar visibility are controlled at the same layer. Use a lightweight preference key for reader controls visibility instead of storing chrome state in ReaderPresentationManager or per-reader close hacks.
Make the reader controls visibility preference helper available to all platforms so shared reader roots compile for macOS as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On iPad, closing the reader after it had hidden the status bar could leave the main interface laid out as if the top safe area were still ignored. The result was content overlapping the status bar after dismissing the full-screen reader.
Approach
Keep status bar ownership at the same layer that owns the full-screen reader presentation. The overlay now reads a lightweight preference emitted by each reader root and uses that local UI state to decide whether the status bar should be hidden.
Scope
ReaderOverlayValidation