fix: restore reader status bar ownership#682
Merged
Conversation
Move status bar visibility back into each reader so it follows the local effective controls state instead of an overlay-shared mirror. This removes the preference bridge and temporary shared UI state, keeps scene-phase recovery in each reader, and prevents iPad safe-area/status-bar regressions when reader controls are hidden and the app is backgrounded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On iPad, if the reader was open with controls hidden and the app was backgrounded, restoring the app could leave the main UI in an incorrect safe-area state. After closing the reader, navigation toolbar buttons could overlap the status bar.
Approach
Move status bar ownership back into each reader so it follows the reader's own effective controls visibility, including local conditions such as zoom, loading, and error states. This removes the temporary overlay-shared controls state and the old preference bridge, while keeping the scene-phase recovery logic inside each reader.
Scope
statusBarHiddendirectly in the DIVINA, EPUB, and PDF readersReaderOverlayReaderControlsVisibilityPreferencehelperValidation
make build-iosmake build-macos