fix: stabilize library picker tint on iOS#688
Merged
Conversation
Apply the stored theme tint inside SheetView on iOS so sheet-hosted navigation stacks keep the app theme after refresh-driven rebuilds. Limit the tint override to iOS to preserve existing macOS and tvOS behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The library picker sheet on iOS could occasionally fall back to the system default tint after a refresh. The issue showed up most often when the sheet rebuilt its navigation content after tapping Refresh.
Approach
Apply the stored theme tint inside
SheetViewso sheet-hostedNavigationStackhierarchies keep a stable tint source even when the sheet content refreshes or rebuilds. Limit the override to iOS so macOS and tvOS continue using their existing behavior.Scope
themeColorHexinsideSheetViewtintandaccentColorto the sheet navigation stack on iOS onlyValidation
make build-ios