fix: animate epub scrolled tap navigation#689
Merged
Conversation
Restore smooth tap navigation in the EPUB scrolled reader by replacing the immediate scrollTop jump with an explicit frame-driven scroll animation that honors the configured tap page transition duration. Also include the related formatter output in the touched EPUB reader and settings files so the branch stays consistent with the repository formatting pass used during validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The EPUB scrolled reader no longer showed a visible scroll animation when tap navigation advanced or rewound the document. The tap path requested smooth scrolling, but then immediately forced the final scroll position, so the transition looked like an instant jump.
Approach
Use an explicit frame-driven scroll animation for scrolled EPUB navigation on both iOS and macOS, and wire it to the existing tap page transition duration setting so tap-driven movement behaves consistently with the rest of the reader.
Scope
scrollTopoverride with cancellable animated scrolling logicValidation
make formatmake build-iosmake build-macos