fix: avoid blank epub settings preview on first advanced layout open#690
Merged
fix: avoid blank epub settings preview on first advanced layout open#690
Conversation
Only mark the EPUB settings preview payload as applied after the WebView JavaScript update succeeds. This prevents the first Advanced Layout expansion from caching a failed preview injection as successful, which could leave the preview blank until another setting changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening Advanced Layout in the EPUB settings sheet could leave the preview blank on the first expansion. The preview only recovered after another setting change triggered a new payload update.
Approach
Keep the preview coordinator state honest by marking a payload as applied only after the WebView JavaScript update succeeds. This avoids caching a failed injection as if it had rendered successfully.
Scope
Validation
make build-ios