fix: prevent live text edge selection from turning pages#692
Merged
Conversation
Prevent the Divina tap-zone bridge from treating Live Text interactions as page-turn taps. When a touch hits recognized Live Text content, the tap-zone recognizer now yields instead of allowing previous/next page actions near the screen edges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Live Text selection near the left or right screen edge could still be interpreted as a tap-to-turn-page action when the user released the selection.
Approach
Tighten the iOS Divina tap-zone gesture handling so touches on recognized Live Text content always yield to VisionKit interactions instead of allowing page-turn taps through.
Scope
Validation
make build-ios