fix: force mobile mode for epub web views#695
Merged
Conversation
Keep iOS and iPad EPUB rendering on the mobile content mode path so Readium always applies the iOS font-size patch. Also clear the iPadOS patch property explicitly to avoid stale injected state. Refs #694.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The EPUB reader still needed iPad-specific patch experiments, but the desktop-content-mode path did not restore working font-size changes on iPad. Keeping separate iPad behavior also made the Readium integration harder to reason about.
Approach
Force every iOS EPUB web view onto the mobile content mode path so Readium consistently uses the iOS font-size patch. The reader payload now always injects the iOS patch and explicitly clears the iPadOS patch flag to avoid stale state during reloads.
Scope
preferredContentMode = .mobile--USER__iPadOSPatchwhile always using--USER__iOSPatchValidation
make formatmake build-iosRefs #694.