fix: normalize offline epub resource keys#702
Merged
Conversation
Align offline EPUB resource lookup with Komga normalized resource keys instead of raw manifest URLs. Keep legacy on-disk lookup compatibility for existing downloads and report normalized chapter keys when local resources are missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
EPUB offline resource lookup reused raw WebPub manifest URLs as local file keys. That leaked server URL shape into local paths, produced confusing
Invalid file URLerrors, and made offline resolution depend on transport-layer URL formatting.Approach
Align offline EPUB lookup with Komga's normalized resource keys, extract EPUB entries using those normalized keys, preserve fallback lookup for previously downloaded on-disk layouts, and report normalized chapter keys when a local resource is missing.
Scope
/resource/keysCURRENT_PROJECT_VERSIONto385Validation
make formatmake build