fix: stabilize reader presentation transitions#704
Merged
Conversation
Smooth Divina and PDF controls overlays by removing scale and bouncy transitions. Preserve the current reading position across reader presentation rebuilds and tighten scroll initial-position recovery so switching between cover, page curl, and scroll modes lands on the expected item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Divina and PDF reader overlay controls used a scaled bouncy transition that felt too springy. More importantly, rebuilding the Divina reader presentation when switching between cover, page curl, scroll, or different reading directions could lose the active reading position, causing jumps to the first or last item or leaving scroll mode waiting in an incorrect initial state.
Approach
Tighten the overlay transitions to simple move-plus-opacity animations, and move the reader presentation state toward explicit ownership in
ReaderViewModelso presentation rebuilds preserve the current page. On the scroll reader path, only mark initial positioning as complete after the target item is actually visible, which lets layout retries finish correctly when transitioning in from cover or page curl.Scope
Validation
make formatmake build