Merged
Conversation
Add a dedicated macOS paged EPUB cover transition view and wire it into the reader flow. Expose the EPUB page transition style setting on macOS and align end-page navigation and cover visuals with the native reader behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
macOS EPUB paged mode only supported scroll transitions, so it could not match the native cover-turn presentation used elsewhere in the reader. The first pass at the cover effect also needed visual parity with Divina, especially for page shadows, opaque page surfaces, and backward turns that should close a page back over the current spread.
Approach
Add a dedicated macOS EPUB cover transition view that reuses the existing EPUB paging state while driving cover-style animations in AppKit/WebKit. Wire the transition style into the macOS EPUB reader and settings surface, keep end-page navigation consistent with keyboard paging, and align the cover visuals so forward turns peel the current page away while backward turns slide the target page back on top.
Scope
WebPubPagedCoverView_macOSfor macOS EPUB cover transitionsValidation
make formatmake build-macos