Merged
Conversation
Add EPUB page transition and overlay controls, including a no-animation paged mode, optional status bar visibility, and a footer progress bar driven by total progression instead of estimated global page counts. Also update the contributor guidance to allow SwiftUI, UIKit, and AppKit based on platform fit rather than enforcing a SwiftUI-first bias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #707 asks for EPUB reader overlay improvements: add a no-animation paged mode, allow keeping the status bar visible while reading, and expose bottom progress without showing misleading global page counts.
The previous footer experiment derived a book-wide page total from client-side pagination, which drifted with viewport size, typography, and chapter load state.
Approach
Add a
nonepage transition option for EPUB paged reading and thread the transition flag through the native paged readers. Keep the footer native, but drive it fromtotalProgressionso it shows only a progress bar instead of fabricated global page numbers.Also expose the new reader overlay preferences in settings and update contributor guidance so SwiftUI, UIKit, and AppKit can be chosen based on platform fit rather than a hard SwiftUI bias.
Scope
Validation
make formatmake buildmake localize./misc/translate.py listIssues