Merged
Conversation
Add a simplified EPUB text alignment preference under advanced layout for iOS and macOS. Map the setting to Readium text alignment and hyphenation overrides, and update the preview and localized strings accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
KMReader's EPUB reader exposed advanced typography controls such as line height and spacing, but it did not provide the common text alignment option readers expect. Users who prefer left-aligned or justified body text had no direct way to choose it.
Approach
Add a simplified text alignment preference under Advanced Layout and map it to Readium's text alignment and hyphenation overrides. The UI now offers publisher default, start alignment, and justify, while hyphenation remains an internal behavior automatically enabled for justified text. The preview was updated so the setting is visible before saving.
Scope
Related
Validation
make formatmake buildmake localize./misc/translate.py list