Merged
Conversation
Add shared page isolation command actions so DIVINA uses the same menu semantics across iOS and macOS. Wire the PDF reader into the macOS Reader command menu, including search, jump, reading direction, page layout, and isolate cover page actions. Extend the macOS reader command state with per-reader capabilities so EPUB, PDF, and DIVINA expose only the commands they actually support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The macOS Reader command menu had drifted from the in-reader controls on iOS. DIVINA was missing current-page isolation actions, and the native PDF reader was not wired into the macOS command menu at all.
Approach
Unify reader command capabilities behind the shared macOS command state, then let each reader expose only the actions it actually supports. DIVINA now reuses shared page-isolation action resolution, and PDF now publishes its own command handlers for search, jump, reading direction, page layout, and cover isolation.
Scope
Validation
make formatmake build