Merged
Conversation
Add a shared detail title view that copies the displayed title text on iOS and macOS. Adopt the shared title view across book, series, oneshot, collection, and read list detail screens while keeping existing title badges intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Detail pages show the title text prominently, but there is no direct way to copy it from the header itself.
Approach
Add a shared
DetailTitleViewthat keeps the title rendering in one place and adds a lightweight copy action on iOS and macOS. Update the book, series, oneshot, collection, and read list detail content views to use the shared title row while preserving existing badges and layout.Scope
Testing
make build